Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kettle] Unpin sdk version of google-cloud #21120

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[Kettle] Unpin sdk version of google-cloud #21120

merged 1 commit into from
Mar 4, 2021

Conversation

MushuEE
Copy link
Contributor

@MushuEE MushuEE commented Mar 2, 2021

#19414

BigQuery error in load operation: Could not connect with BigQuery server due to:
RedirectMissingLocation('Redirected but the response is missing a Location:
header.',) was introduced in 294+ version and was fixed in 312+ versions, we are at 320 today.

/area kettle

@k8s-ci-robot k8s-ci-robot added area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2021
@k8s-ci-robot k8s-ci-robot requested review from amwat and spiffxp March 2, 2021 23:42
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2021
amwat
amwat reviewed Mar 3, 2021
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything this means we should pin harder?
so that casual changes don't break us

kettle/Dockerfile Outdated Show resolved Hide resolved
@MushuEE
Update google cloud sdk
cf51299 
Versions 312+ (current 320) fix issue that caused original pin

Build now takes longer so timeout was increased
amwat
amwat reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, MushuEE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2ee80ae into kubernetes:master Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 4, 2021
@BenTheElder BenTheElder mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat amwat left review comments

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@MushuEE @k8s-ci-robot @spiffxp @amwat